Openfire (ARCHIVED)

XMPPServerInfo should make a distinction between 'hostname' and 'xmpp domain name'

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.5.0
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Description

XMPPServerInfo should report both the XMPP domain identifier of Openfire, as well as the hostname of the local node. Currently, it has just one method, that is confusingly named: #getName().

I would propose to remove the naming confusion as well as to add an additional getter. To do this, the #getName() method can be replaced with two others: #getXmppDomain() and #getHostname(), which return the corresponding identifiers.

To retain backwards compatibility, the old #getName method (and the corresponding #setName()) should not be removed, but marked as 'deprecated'.

Activity

Hide
Guus der Kinderen added a comment -

I have attached a patch that adds the described functionality.

Note that the patch will also make sure that modifying the Date object returned by XMPPServerInfoImpl#getLastStarted() no longer modifies the internal representation of that Date in XMPPServerInfoImpl.

Show
Guus der Kinderen added a comment - I have attached a patch that adds the described functionality. Note that the patch will also make sure that modifying the Date object returned by XMPPServerInfoImpl#getLastStarted() no longer modifies the internal representation of that Date in XMPPServerInfoImpl.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: