Openfire (ARCHIVED)

fix Potential stream compression bug

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 3.3.2, 3.4.0 Beta 1
  • Fix Version/s: 3.6.2
  • Component/s: Core
  • Labels:
    None
  • Acceptance Test - Add?:
    No

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
LG added a comment -

see also http://www.igniterealtime.org/community/thread/33000

Show
LG added a comment - see also http://www.igniterealtime.org/community/thread/33000
Hide
Permalink
Daryl Herzmann added a comment -

Hi,

For anybody still watching, what is the status on this issue? LG's comment link has a patch included...

daryl

Show
Daryl Herzmann added a comment - Hi, For anybody still watching, what is the status on this issue? LG's comment link has a patch included... daryl
Hide
Permalink
LG added a comment -

see also http://www.igniterealtime.org/community/thread/34824 ... so still a problem in 3.6.0

Show
LG added a comment - see also http://www.igniterealtime.org/community/thread/34824 ... so still a problem in 3.6.0
Hide
Permalink
Walter Ebeling added a comment -

Here is a patch that has to be confirmed by the community:

— C:\develop\instango\openfire_src\mina\mina-1.1.7\filter-compression\src\main\ja va\org\apache\mina\filter\support\Zlib.java.orig Sat Apr 19 14:32:28 2008 UTC
+++ C:\develop\instango\openfire_src\mina\mina-1.1.7\filter-compression\src\main\ja va\org\apache\mina\filter\support\Zlib.java Tue Oct 14 18:38:08 2008 UTC
@@ -152,7 +152,7 @@

  • released manually.
  • @throws IOException if the compression of teh buffer failed for some reason
    */
  • public ByteBuffer deflate(ByteBuffer inBuffer) throws IOException {
    + synchronized public ByteBuffer deflate(ByteBuffer inBuffer) throws IOException {
    if (mode == MODE_INFLATER) { throw new IllegalStateException("not initialized as DEFLATER"); }
Show
Walter Ebeling added a comment - Here is a patch that has to be confirmed by the community: — C:\develop\instango\openfire_src\mina\mina-1.1.7\filter-compression\src\main\ja va\org\apache\mina\filter\support\Zlib.java.orig Sat Apr 19 14:32:28 2008 UTC +++ C:\develop\instango\openfire_src\mina\mina-1.1.7\filter-compression\src\main\ja va\org\apache\mina\filter\support\Zlib.java Tue Oct 14 18:38:08 2008 UTC @@ -152,7 +152,7 @@
  • released manually.
  • @throws IOException if the compression of teh buffer failed for some reason */
  • public ByteBuffer deflate(ByteBuffer inBuffer) throws IOException { + synchronized public ByteBuffer deflate(ByteBuffer inBuffer) throws IOException { if (mode == MODE_INFLATER) { throw new IllegalStateException("not initialized as DEFLATER"); }
Hide
Permalink
Walter Ebeling added a comment -

Patch provided by Henrik Pfluger and tested on his installation:

http://www.igniterealtime.org/community/message/180622#180622

Show
Walter Ebeling added a comment - Patch provided by Henrik Pfluger and tested on his installation: http://www.igniterealtime.org/community/message/180622#180622
Hide
Permalink
Daryl Herzmann added a comment -

assigning against 3.6.1 to get it on the current radar. may get bumped...

Show
Daryl Herzmann added a comment - assigning against 3.6.1 to get it on the current radar. may get bumped...
Hide
Permalink
Gaston Dombiak added a comment -

Was this fix tested and confirmed by other people? I would love to send it to MINA devs so they can include it but first I want to confirm that we are in the right path.

Show
Gaston Dombiak added a comment - Was this fix tested and confirmed by other people? I would love to send it to MINA devs so they can include it but first I want to confirm that we are in the right path.
Hide
Permalink
Walter Ebeling added a comment -

There are no know confirmations and we are running on pre 3.6.0 OF. How about including it in 3.6.1 beta and go for beta testers confirmation? This bug is only happening in load situations and that would require someone going boldly where no one has gone before (beta installation in production). I think we would go for that 8my team will be upset . . .)

Or Gato is doing his load testing dance again . . . . .

Show
Walter Ebeling added a comment - There are no know confirmations and we are running on pre 3.6.0 OF. How about including it in 3.6.1 beta and go for beta testers confirmation? This bug is only happening in load situations and that would require someone going boldly where no one has gone before (beta installation in production). I think we would go for that 8my team will be upset . . .) Or Gato is doing his load testing dance again . . . . .
Hide
Permalink
Walter Ebeling added a comment -

I can confirm this patch. No more zlib errors on our installation (1300 concurrent users).

Show
Walter Ebeling added a comment - I can confirm this patch. No more zlib errors on our installation (1300 concurrent users).

People

Vote (15)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for igniterealtime.org. Try JIRA - bug tracking software for your team.