Openfire (ARCHIVED)

Pluginmanager improvements

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.3.0
  • Fix Version/s: 3.6.2
  • Component/s: Plugins
  • Acceptance Test - Add?:
    No
  • Description:
    Hide

    Incorporate the attached plugin manager patch. From aznidin:

    "With the existing code, a parent plugin's destroyPlugin() is called more than once, addition of which is caused by the number of children plugins. It's the side effect of recursion. The key point is to call parentPluginMap.remove() and childPluginMap.remove() first before recursing the unloadPlugin().

    Also, I've added some more codes into PluginManager.java for proper PluginListener implementation. Still a recursion effect and the order of plugins destroyed, the PluginListener.pluginDestroyed() isn't called whenever it should be. Additional info is provided as source comments. Please see the diff file attached."

    Show
    Incorporate the attached plugin manager patch. From aznidin: "With the existing code, a parent plugin's destroyPlugin() is called more than once, addition of which is caused by the number of children plugins. It's the side effect of recursion. The key point is to call parentPluginMap.remove() and childPluginMap.remove() first before recursing the unloadPlugin(). Also, I've added some more codes into PluginManager.java for proper PluginListener implementation. Still a recursion effect and the order of plugins destroyed, the PluginListener.pluginDestroyed() isn't called whenever it should be. Additional info is provided as source comments. Please see the diff file attached."

Attachments

  1. Text File
    PluginManager.patch
    (4 kB)
    Matt Tucker
    04/24/07 01:45 AM

Activity

Ascending order - Click to sort in descending order
Matt Tucker made changes - 04/24/07 01:45 AM
Field Original Value New Value
Attachment PluginManager.patch [ 10412 ]
Gaston Dombiak made changes - 11/17/08 08:52 AM
Fix Version/s 3.6.2 [ 10832 ]
Hide
Permalink
Gaston Dombiak added a comment - 11/17/08 08:53 AM

Testing of the fix is pending. Code is in SVN now.

Show
Gaston Dombiak added a comment - 11/17/08 08:53 AM Testing of the fix is pending. Code is in SVN now.
Gaston Dombiak made changes - 11/17/08 08:53 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
wroot added a comment - 11/18/08 12:15 AM

I have tried openfire_2008-11-17 nightly, but it has no affect on my problem with uninstalling the plugins. This happens only on my Windows box. Linux box is working fine with that. Uninstall takes a minute or so. Then it will show that plugin was uninstalled, but it still lists that plugin on the Plugins page as installed. After another few minutes it will finally dissapear. But he folder of such plugin in /openfire/plugins/ will stay until next openfire start. If i try to uninstall another plugin, then suddenly first uninstalled plugin appears on the list again.

Show
wroot added a comment - 11/18/08 12:15 AM I have tried openfire_2008-11-17 nightly, but it has no affect on my problem with uninstalling the plugins. This happens only on my Windows box. Linux box is working fine with that. Uninstall takes a minute or so. Then it will show that plugin was uninstalled, but it still lists that plugin on the Plugins page as installed. After another few minutes it will finally dissapear. But he folder of such plugin in /openfire/plugins/ will stay until next openfire start. If i try to uninstall another plugin, then suddenly first uninstalled plugin appears on the list again.
Gaston Dombiak made changes - 11/21/08 06:55 AM
Status Resolved [ 5 ] Closed [ 6 ]

People

Dates

  • Created:
    04/24/07 01:45 AM
    Updated:
    11/21/08 06:55 AM
    Resolved:
    11/17/08 08:53 AM
Atlassian JIRA (v4.1.2#531) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for igniterealtime.org. Try JIRA - bug tracking software for your team.